Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic layout from figma #771

Closed
wants to merge 4 commits into from
Closed

Conversation

wkande
Copy link
Member

@wkande wkande commented Jul 8, 2024

This branch changes the landing page to use some layout features from a figma page.

----- Do not merge this PR -----
A final approval by T is needed.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Visit the preview URL for this PR (updated for commit 7ae10f6):

https://vitepress-docs--pr771-20240708-update-home-tfgr3sze.web.app

(expires Wed, 17 Jul 2024 10:38:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is ready for review, but it might be worth noting the mobile (android) view of the new section isn't rendering cleanly (screenshot).

image

@wkande
Copy link
Member Author

wkande commented Jul 10, 2024

@dcroote can you try it again on the Android device

@dcroote
Copy link
Collaborator

dcroote commented Jul 10, 2024

@dcroote can you try it again on the Android device

Looks good now 👍

@wkande
Copy link
Member Author

wkande commented Aug 29, 2024

These changes will not be implemented.

@wkande wkande closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants